SRE-3706: Add yamllint and copyright checks#7
Merged
Conversation
JohnMalmberg
force-pushed
the
sre-3706-copyright
branch
4 times, most recently
from
7b97964 to
d40fc49
Compare
Contributor
Author
|
https://github.com/daos-stack/system-pipeline-lib/actions/runs/24915986233/job/72968019500?pr=21 test with consumer got the expected failures. |
- Add changed-file detection and runner wiring for Python files. - Run flake8 and pylint as a unified meta-linter on discovered *.py files and files without an extension that declare a Python shebang. Changed files/directories - bin/run-linters.sh, checks/detect-linters.sh, checks/linter-common.sh: add linter_is_python_candidate() with shebang detection for files without an extension, python_needed flag, and dispatch wiring. - checks/install-linter-tools.sh: add flake8 and pylint to package list with dnf/yum name mapping. - checks/linters/python/: add Python meta-linter scripts (run.sh and run.ps1) running both flake8 and pylint on the same file set. - docs/linters.md: update linter list with python description and tool requirements. - vscode-project-words.txt: add flake8, pylint to project word list. Signed-off-by: John E. Malmberg <john.malmberg@hpe.com>
JohnMalmberg
force-pushed
the
sre-3706-python
branch
from
7cc72ac to
86843ca
Compare
- Add a yamllint script for `*.yml`, `*.yaml`, `.yamllint`, and `.ansible-lint` files. - Add a copyright script with `--fix` support to insert the standard `Hewlett Packard Enterprise Development LP` header in candidate files. - Add commit message formatting guidance and update linter documentation. Changed files/directories - bin/run-linters.sh, checks/detect-linters.sh, checks/linter-common.sh: add yaml and copyright candidate selection and dispatch wiring. - checks/install-linter-tools.sh: add yamllint package installation mapping. - checks/linters/yamllint/: add yamllint lint scripts (run.sh and run.ps1). - checks/linters/copyright/: add copyright check scripts (run.sh and run.ps1) with `--fix` support. - docs/linters.md, docs/usage.md, docs/git-commit-message-guidelines.md: update linter docs and add commit message guidance. - vscode-project-words.txt: add yamllint to project word list. Signed-off-by: John E. Malmberg <john.malmberg@hpe.com>
JohnMalmberg
force-pushed
the
sre-3706-copyright
branch
from
d40fc49 to
038e75c
Compare
janekmi
requested changes
Apr 27, 2026
Signed-off-by: John E. Malmberg <john.malmberg@hpe.com>
JohnMalmberg
commented
Apr 27, 2026
JohnMalmberg
left a comment
JohnMalmberg
left a comment
Contributor
Author
There was a problem hiding this comment.
Pushed an update.
JohnMalmberg
requested review from
grom72,
janekmi,
jzarzycki,
osalyk and
ryon-jensen
Signed-off-by: John E. Malmberg <john.malmberg@hpe.com>
setup-dev.sh was generating log noise testing for npm-groovy-lint needs. Signed-off-by: John E. Malmberg <john.malmberg@hpe.com>
janekmi
requested changes
Apr 28, 2026
JohnMalmberg
commented
Apr 29, 2026
JohnMalmberg
left a comment
JohnMalmberg
left a comment
Contributor
Author
There was a problem hiding this comment.
Will try to push an update tomorrow to address most of these issues and some other issues found in some more tests being done.
Also includes bugfixes found in testing as a submodule. - .github/dependabot.yml: Enable dependabot scanning of this repository. - checks/guard-jenkins-library-pin.sh: Block landing of Jenkinsfiles that pin a library version. Signed-off-by: John E. Malmberg <john.malmberg@hpe.com>
Signed-off-by: John E. Malmberg <john.malmberg@hpe.com>
janekmi
requested changes
May 13, 2026
Signed-off-by: John E. Malmberg <john.malmberg@hpe.com>
janekmi
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
*.yml,*.yaml,.yamllint, and.ansible-lintfiles.--fixsupport to insert the standardHewlett Packard Enterprise Development LPheader in candidate files.Changed files/directories
--fixsupport.